[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/5] docker: Sort Fedora packages (i386-cross)
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PULL 2/5] docker: Sort Fedora packages (i386-cross) |
Date: |
Mon, 10 Sep 2018 11:57:16 +0800 |
From: Philippe Mathieu-Daudé <address@hidden>
As recommended in
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#sort-multi-line-arguments
"This helps to avoid duplication of packages and make the
list much easier to update. This also makes PRs a lot easier
to read and review."
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
---
tests/docker/dockerfiles/fedora-i386-cross.docker | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tests/docker/dockerfiles/fedora-i386-cross.docker
b/tests/docker/dockerfiles/fedora-i386-cross.docker
index 8fbef2fa53..a4fd895b07 100644
--- a/tests/docker/dockerfiles/fedora-i386-cross.docker
+++ b/tests/docker/dockerfiles/fedora-i386-cross.docker
@@ -1,14 +1,13 @@
FROM fedora:latest
ENV PACKAGES \
gcc \
- glibc-static.i686 \
+ glib2-devel.i686 \
glibc-devel.i686 \
- glib2-devel.i686 \
- zlib-devel.i686 \
- glib2-devel.i686 \
+ glibc-static.i686 \
+ gnutls-devel.i686 \
nettle-devel.i686 \
pixman-devel.i686 \
- gnutls-devel.i686
+ zlib-devel.i686
RUN dnf install -y $PACKAGES
RUN rpm -q $PACKAGES | sort > /packages.txt
--
2.17.1
- [Qemu-devel] [PULL 0/5] Docker patches, Fam Zheng, 2018/09/09
- [Qemu-devel] [PULL 1/5] docker: Sort Fedora packages, Fam Zheng, 2018/09/09
- [Qemu-devel] [PULL 2/5] docker: Sort Fedora packages (i386-cross),
Fam Zheng <=
- [Qemu-devel] [PULL 3/5] docker: Sort Ubuntu packages, Fam Zheng, 2018/09/09
- [Qemu-devel] [PULL 4/5] docker: Sort CentOS packages, Fam Zheng, 2018/09/09
- [Qemu-devel] [PULL 5/5] docker: Clean dangling tarball files, Fam Zheng, 2018/09/09
- Re: [Qemu-devel] [PULL 0/5] Docker patches, Peter Maydell, 2018/09/25