Re: [Qemu-devel] [PATCH] RISC-V - Dynamic parameterization of RISC-V memory map

[Michael Eager]

On 09/06/2018 08:44 AM, Peter Maydell wrote:
> On 6 September 2018 at 16:07, Michael Eager <address@hidden> wrote:
> > Any comments?
>
> I'd quite like to hear from somebody more familiar with the
> readconfig/writeconfig stuff than me about whether this
> very riscv-centric approach makes sense and fits with how
> the config file is used by other parts of QEMU.

Hi Peter --

This patch is specific to RISC-V, but it would be easy to generalize it 
to any target.  It could also be extended to describe other processor 
features, for example, the number of cores.

Generalizing it would involve refactoring the changes to create a 
generic routine which could be used in any target.

> I'm not sure who would be best to do that review, though. Paolo,
> any suggestions for who knows that bit of the code?
>
> thanks
> -- PMM
>
> > On 08/30/2018 09:22 AM, Michael Eager wrote:
> > > Corrected patch attached.
> > >
> > > On 08/29/2018 05:48 PM, Michael Eager wrote:
> > > > Whoops.  I just noticed that this patch is against the riscv-qemu
> > > > repo on github, not the qemu.org repo.  I will rework it for the qemu.org
> > > > repo.  Meanwhile, I welcome any comments.
> > > >
> > > > On 08/29/2018 05:21 PM, Michael Eager wrote:
> > > > > Memory parameters for RISC-V boards can be read from a configuration
> > > > > file using the -readconfig command line option.  The configuration file
> > > > > should have a section for the board and memory.  The configuration for
> > > > > the VirtIO board has the following configuration variables:
> > > > > [riscv-virt-mem]
> > > > >     debug-base   = "0x0"
> > > > >     debug-size   = "0x100"
> > > > >     mrom-base    = "0x1000"
> > > > >     mrom-size    = "0x11000"
> > > > >     test-base    = "0x100000"
> > > > >     test-size    = "0x1000"
> > > > >     clint-base   = "0x2000000"
> > > > >     clint-size   = "0x10000"
> > > > >     plic-base    = "0xc000000"
> > > > >     plic-size    = "0x4000000"
> > > > >     uart0-base   = "0x10000000"
> > > > >     uart0-size   = "0x100"
> > > > >     virtio-base  = "0x10001000"
> > > > >     virtio-size  = "0x1000"
> > > > >     dram-base    = "0x80000000"
> > > > >     dram-size    = "0x0"
> > > > >
> > > > > Values must be enclosed within quotes.
> > > > >
> > > > > Signed-off-by: Michael Eager <address@hidden>
> >
> > --
> > Michael Eager    address@hidden
> > 1960 Park Blvd., Palo Alto, CA 94306

--
Michael Eager    address@hidden
1960 Park Blvd., Palo Alto, CA 94306