[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/10] qemu-option: improve qemu_opts_print_help
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 02/10] qemu-option: improve qemu_opts_print_help() output |
Date: |
Thu, 6 Sep 2018 10:30:32 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 09/06/2018 10:12 AM, Marc-André Lureau wrote:
Modify qemu_opts_print_help():
- to print expected argument type
- skip description if not available
- sort lines
- prefix with the list name (like qdev, to avoid confusion)
- drop 16-chars alignment, use a '-' as seperator for option name and
description
For ex, "-spice ?" output is changed from:
s/?/help/
port No description available
tls-port No description available
addr No description available
[...]
gl No description available
rendernode No description available
to:
spice.addr=str
spice.agent-mouse=bool (on/off)
spice.disable-agent-file-xfer=bool (on/off)
[...]
spice.x509-key-password=str
spice.zlib-glz-wan-compression=str
"qemu-img create -f qcow2 -o ?", changed from:
and again
size Virtual disk size
compat Compatibility level (0.10 or 1.1)
backing_file File name of a base image
[...]
lazy_refcounts Postpone refcount updates
refcount_bits Width of a reference count entry in bits
to:
backing_file=str - File name of a base image
backing_fmt=str - Image format of the base image
cluster_size=size - qcow2 cluster size
[...]
refcount_bits=num - Width of a reference count entry in bits
size=size - Virtual disk size
Signed-off-by: Marc-André Lureau <address@hidden>
---
util/qemu-option.c | 44 ++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 42 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [Qemu-devel] [PATCH 00/10] Various qemu command line options help improvements, Marc-André Lureau, 2018/09/06
- [Qemu-devel] [PATCH 01/10] qemu-option: add help fallback to print the list of options, Marc-André Lureau, 2018/09/06
- [Qemu-devel] [PATCH 03/10] qom/object: fix iterating properties over a class, Marc-André Lureau, 2018/09/06
- [Qemu-devel] [PATCH 02/10] qemu-option: improve qemu_opts_print_help() output, Marc-André Lureau, 2018/09/06
- Re: [Qemu-devel] [PATCH 02/10] qemu-option: improve qemu_opts_print_help() output,
Eric Blake <=
- [Qemu-devel] [PATCH 04/10] qom/object: register 'type' property as class property, Marc-André Lureau, 2018/09/06
- [Qemu-devel] [PATCH 06/10] tests/qom-proplist: check properties are not listed multiple times, Marc-André Lureau, 2018/09/06
- [Qemu-devel] [PATCH 07/10] tests/qom-proplist: check class properties iterator, Marc-André Lureau, 2018/09/06
- [Qemu-devel] [PATCH 08/10] vl: handle -object ?, Marc-André Lureau, 2018/09/06
- [Qemu-devel] [PATCH 05/10] tests/qom-proplist: check duplicate "bv" property registration failed, Marc-André Lureau, 2018/09/06
- [Qemu-devel] [PATCH 09/10] hostmem: add some properties description, Marc-André Lureau, 2018/09/06
- [Qemu-devel] [PATCH 10/10] vl: list user creatable propeties if '?' as argument, Marc-André Lureau, 2018/09/06