Re: [Qemu-devel] [PATCH] tests: vm: auto_install OpenBSD

[Brad Smith]

On 8/27/2018 5:18 AM, Fam Zheng wrote:

> On Fri, 08/24 10:36, Brad Smith wrote:
> > I very much appreciate the effort to bump up to 6.3 as I was going
> > to suggest doing that at some point. But bumping up to 6.3 at the
> > moment will fail with the configure script. We've switched from GCC 4.2
> > to Clang. The TLS check will fail with Clang's emulated TLS. We've
> > had a local patch for awhile to fix the test but I don't think it is
> > appropriate to upstream as is.
> >
> > Index: configure
> > --- configure.orig
> > +++ configure
> > @@ -1876,7 +1876,7 @@ static __thread int tls_var;
> >   int main(void) { return tls_var; }
> >   EOF
> > -if ! compile_prog "-Werror" "" ; then
> > +if ! compile_prog "-Werror" "-pthread" ; then
> >       error_exit "Your compiler does not support the __thread specifier for " \
> >         "Thread-Local Storage (TLS). Please upgrade to a version that does."
> >   fi
> Are you suggesting we use 6.2 for now?
>
> Fam

Disregard what I said earlier. It seems something has changed along the 
way since we
first brought in Clang and the patch is no longer necessary. Please go 
ahead with 6.3 as is.