qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V2 0/3] Formatted INFO files to fit Markdown (.m


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH V2 0/3] Formatted INFO files to fit Markdown (.md) format.
Date: Tue, 4 Sep 2018 14:44:17 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 09/02/2018 12:53 PM, Yoni Bettan wrote:
This patch make INFO files (e.g. README, CODING_STYLE and HACKING) much more
readable when watched from GitHub GUI.

./VERSION, ./MAINTAINERS were leave untouched otherwise
./scripts/get_maintainer.pl breaks.

./COPYING, ./LICENSE ./COPYING.LIB were leave untouched because it look likes
they come from GNU and not QEMU.

Visualization of the change can be found at
https://github.com/ybettan/qemu/tree/md.
NOTE:
This last part of the message should be removed from the commit message
since I will remove the 'md' branch from my fork if the patch is
accepted.

I'm a bit late to the thread, but wanted to point out this tangent:

Note that the cover letter is not committed into git, so a disclaimer about removing the last paragraph of the cover letter is pointless.

Had this been an actual commit message, it's best to stick such disclaimers (which are useful to reviewers, but not to long-term git log) after the --- that separates the actual commit message from the patch (as 'git am' will automatically strip such disclaimers when a maintainer takes in your patch for merging through their tree).

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]