[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 13/15] gdbstub: gdb_set_stop_cpu: ignore request whe
From: |
Luc Michel |
Subject: |
[Qemu-devel] [PATCH 13/15] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached |
Date: |
Sat, 1 Sep 2018 14:46:37 +0200 |
When gdb_set_stop_cpu() is called with a CPU associated to a process
currently not attached by the GDB client, return without modifying the
stop CPU. Otherwise, GDB get confused if it receives packets with a
thread-id it does not know about.
Signed-off-by: Luc Michel <address@hidden>
---
gdbstub.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/gdbstub.c b/gdbstub.c
index 36ed7081ea..6a55bf2785 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1759,10 +1759,19 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
return RS_IDLE;
}
void gdb_set_stop_cpu(CPUState *cpu)
{
+ GDBProcess *p = gdb_get_cpu_process(gdbserver_state, cpu);
+
+ if (!p->attached) {
+ /* Having a stop CPU corresponding to a process that is not attached
+ * confuses GDB. So we ignore the request.
+ */
+ return;
+ }
+
gdbserver_state->c_cpu = cpu;
gdbserver_state->g_cpu = cpu;
}
#ifndef CONFIG_USER_ONLY
--
2.18.0
- [Qemu-devel] [PATCH 02/15] gdbstub: add multiprocess support to '?' packets, (continued)
- [Qemu-devel] [PATCH 02/15] gdbstub: add multiprocess support to '?' packets, Luc Michel, 2018/09/01
- [Qemu-devel] [PATCH 03/15] gdbstub: add multiprocess support to 'H' and 'T' packets, Luc Michel, 2018/09/01
- [Qemu-devel] [PATCH 01/15] gdbstub: introduce GDB processes, Luc Michel, 2018/09/01
- [Qemu-devel] [PATCH 12/15] gdbstub: processes initialization on new peer connection, Luc Michel, 2018/09/01
- [Qemu-devel] [PATCH 06/15] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo, Luc Michel, 2018/09/01
- [Qemu-devel] [PATCH 09/15] gdbstub: add multiprocess support to 'D' packets, Luc Michel, 2018/09/01
- [Qemu-devel] [PATCH 15/15] arm/xlnx-zynqmp: put APUs and RPUs in separate GDB groups, Luc Michel, 2018/09/01
- [Qemu-devel] [PATCH 13/15] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached,
Luc Michel <=
- [Qemu-devel] [PATCH 14/15] gdbstub: add multiprocess extension support, Luc Michel, 2018/09/01