[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 10/10] qmp: common 'id' handling & make QGA c
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 10/10] qmp: common 'id' handling & make QGA conform to QMP spec |
Date: |
Sat, 01 Sep 2018 12:59:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Let qmp_dispatch() copy the 'id' field. That way any qmp client will
> conform to the specification, including QGA. Furthermore, it
> simplifies the work for qemu monitor.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> Reviewed-by: Michael Roth <address@hidden>
> ---
> monitor.c | 33 ++++++++++++---------------------
> qapi/qmp-dispatch.c | 10 ++++++++--
> tests/test-qga.c | 13 +++++--------
> 3 files changed, 25 insertions(+), 31 deletions(-)
Let's squash in
diff --git a/docs/interop/qmp-spec.txt b/docs/interop/qmp-spec.txt
index 8f7da0245d..5fdfb2a4d0 100644
--- a/docs/interop/qmp-spec.txt
+++ b/docs/interop/qmp-spec.txt
@@ -109,6 +109,7 @@ or
command execution, it is optional and will be part of the response
if provided. The "id" member can be any json-value. A json-number
incremented for each successive command works fine.
+- Older versions of the QEMU Guest agent do not support "id".
2.3.1 Out-of-band execution
---------------------------
- Re: [Qemu-devel] [PATCH v4 10/10] qmp: common 'id' handling & make QGA conform to QMP spec,
Markus Armbruster <=