[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 3/8] block: Null pointer dereference in blk_root_
From: |
Liam Merwick |
Subject: |
[Qemu-devel] [PATCH v3 3/8] block: Null pointer dereference in blk_root_get_parent_desc() |
Date: |
Fri, 31 Aug 2018 19:16:07 +0100 |
The dev_id returned by the call to blk_get_attached_dev_id() in
blk_root_get_parent_desc() can be NULL (an internal call to
object_get_canonical_path may have returned NULL) so it should
be checked before dereferencing.
Signed-off-by: Liam Merwick <address@hidden>
Reviewed-by: Darren Kenny <address@hidden>
Reviewed-by: Mark Kanda <address@hidden>
---
block/block-backend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index fa120630be83..210eee75006a 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -136,7 +136,7 @@ static char *blk_root_get_parent_desc(BdrvChild *child)
}
dev_id = blk_get_attached_dev_id(blk);
- if (*dev_id) {
+ if (dev_id && *dev_id) {
return dev_id;
} else {
/* TODO Callback into the BB owner for something more detailed */
--
1.8.3.1
- [Qemu-devel] [PATCH v3 0/8] off-by-one and NULL pointer accesses detected by static analysis, Liam Merwick, 2018/08/31
- [Qemu-devel] [PATCH v3 2/8] job: Fix off-by-one assert checks for JobSTT and JobVerbTable, Liam Merwick, 2018/08/31
- [Qemu-devel] [PATCH v3 5/8] block: Fix potential Null pointer dereferences in vvfat.c, Liam Merwick, 2018/08/31
- [Qemu-devel] [PATCH v3 1/8] configure: Provide option to explicitly disable AVX2, Liam Merwick, 2018/08/31
- [Qemu-devel] [PATCH v3 3/8] block: Null pointer dereference in blk_root_get_parent_desc(),
Liam Merwick <=
- [Qemu-devel] [PATCH v3 4/8] qemu-img: potential Null pointer deref in img_commit(), Liam Merwick, 2018/08/31
- [Qemu-devel] [PATCH v3 6/8] block: dump_qlist() may dereference a Null pointer, Liam Merwick, 2018/08/31
- [Qemu-devel] [PATCH v3 7/8] io: potential unnecessary check in qio_channel_command_new_spawn(), Liam Merwick, 2018/08/31
- [Qemu-devel] [PATCH v3 8/8] qcow2: Read outside array bounds in qcow2_pre_write_overlap_check(), Liam Merwick, 2018/08/31