Re: [Qemu-devel] [PATCH v9 1/6] hw/i386: add pc-i440fx-3.1 & pc-q35-3.1

[Eduardo Habkost]

On Thu, Aug 30, 2018 at 09:54:05AM -0400, Stefan Berger wrote:
> On 08/28/2018 10:05 AM, Marc-André Lureau wrote:
> > ping
> > On Fri, Aug 10, 2018 at 5:34 PM Marc-André Lureau
> > <address@hidden> wrote:
> > > The following patch is going to add compatiblity parameters.
> > > 
> > > Signed-off-by: Marc-André Lureau <address@hidden>
> > > ---
> > >   include/hw/compat.h  |  4 +++-
> > >   include/hw/i386/pc.h |  5 ++++-
> > >   hw/i386/pc_piix.c    | 13 ++++++++++++-
> > >   hw/i386/pc_q35.c     | 12 +++++++++++-
> > >   4 files changed, 30 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/include/hw/compat.h b/include/hw/compat.h
> > > index c08f4040bb..f8e596969a 100644
> > > --- a/include/hw/compat.h
> > > +++ b/include/hw/compat.h
> > > @@ -1,7 +1,9 @@
> > >   #ifndef HW_COMPAT_H
> > >   #define HW_COMPAT_H
> > > 
> > > -#define HW_COMPAT_2_12 \
> > > +#define HW_COMPAT_3_0
> Should probably be 3_1 now?

*_COMPAT_3_1 will exist only on QEMU 3.2, just like *_COMPAT_2_12
exists only on QEMU 3.0 and newer.

We need the compat macros to implement compatibility with older
QEMU versions.  We don't need compat macros for the current QEMU
version.


-- 
Eduardo