qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 07/10] check: Only test boot-serial when sga


From: Daniel P . Berrangé
Subject: Re: [Qemu-devel] [PATCH v3 07/10] check: Only test boot-serial when sga is compiled in
Date: Tue, 28 Aug 2018 09:19:20 +0100
User-agent: Mutt/1.10.1 (2018-07-13)

On Mon, Aug 27, 2018 at 12:53:21PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > The only way we can stop using "-device sga" is if we either have
> > something explicit in the XML saying whether to use it or not, or
> > alternatively have some indicator associated with the next versioned
> > machine type that we can hook off.
> 
> How does libvirt query the machine type properties?

libvirt is able to query properties against i440FX-pcihost and
q35-pcihost devices - currently we only look for one prop:

static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsI440FXPCIHost[] = {
    { "pci-hole64-size", QEMU_CAPS_I440FX_PCI_HOLE64_SIZE },
};

static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsQ35PCIHost[] = {
    { "pci-hole64-size", QEMU_CAPS_Q35_PCI_HOLE64_SIZE },
};

Not sure if that's the kind of thing you're looking for ?

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]