|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH 5/6] json: Eliminate lexer state IN_ERROR |
Date: | Mon, 27 Aug 2018 12:29:31 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/27/2018 02:00 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster <address@hidden> --- qobject/json-lexer.c | 9 +++++---- qobject/json-parser-int.h | 8 ++++---- 2 files changed, 9 insertions(+), 8 deletions(-)
- typedef enum json_token_type { - JSON_MIN = 100, - JSON_LCURLY = JSON_MIN, + JSON_ERROR = 0, /* must be zero, see json_lexer[] */ + /* Gap for lexer states */ + JSON_LCURLY = 100, + JSON_MIN = JSON_LCURLY,
In an earlier version of this type of cleanup, you swapped the IN_ and JSON_ values and eliminated the gap, to make the overall table more compact (no storage wasted on any of the states in the gap between the two).
https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg01178.htmlIs it still worth trying to minimize the gap between the two sequences, even if you now no longer swap them in order?
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |