Re: [Qemu-devel] [PATCH v3 6/9] tests: add a few qmp tests

[Thomas Huth]

On 2018-08-25 15:57, Marc-André Lureau wrote:
> test_object_add_without_props() tests a bug in qmp_object_add() we
> fixed in commit e64c75a975.  Sadly, we don't have systematic
> object-add tests.  This lone test can go into qmp-cmd-test for want of
> a better home.
> 
> test_qom_set_without_value() is about a bug in infrastructure used by
> the QMP core, fixed in commit c489780203.  We covered the bug in
> infrastructure unit tests (commit bce3035a44).  I wrote that test
> earlier, to cover QMP level as well, the test could go into qmp-test.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  tests/qmp-cmd-test.c | 31 +++++++++++++++++++++++++++++++
>  tests/qmp-test.c     | 18 ++++++++++++++++++
>  2 files changed, 49 insertions(+)

Reviewed-by: Thomas Huth <address@hidden>