Re: [Qemu-devel] [PATCH v2] editorconfig: set emacs mode

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> Some time ago, I proposed to use an (eval) in .dir-locals.el to set
> the mode for all json files and Makefile. Unfortunately, this isn't
> safe, and emacs will prompt the user, which isn't very friendly.
>
> Fortunately, editorconfig provides a special config key which does
> allow to set the emacs mode. Add a few missing entries and set the
> emacs mode.

Please mention editorconfig requires a plugin to work.  Without that,
the reader is left to wonder why we keep the "redundant" Emacs file
local variables.

>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  .editorconfig | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/.editorconfig b/.editorconfig
> index b2022e391a..683c543be3 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -6,10 +6,23 @@ end_of_line = lf
>  insert_final_newline = true
>  charset = utf-8
>  
> +[*.mak]
> +indent_style = tab
> +indent_size = 8
> +file_type_emacs = makefile
> +

Aside: we should name these .mk like a sane person.

>  [Makefile*]
>  indent_style = tab
>  indent_size = 8
> +file_type_emacs = makefile
>  
>  [*.{c,h}]
>  indent_style = space
>  indent_size = 4
> +
> +[*.{vert,frag}]
> +file_type_emacs = glsl
> +
> +[*.json]
> +indent_style = space
> +file_type_emacs = python

With the commit message improved:
Acked-by: Markus Armbruster <address@hidden>