Re: [Qemu-devel] [PULL v3 00/69] Misc patches for 2018-08-21

[Paolo Bonzini]

On 23/08/2018 18:16, Peter Maydell wrote:
> 
> tests/libqtest.c: In function 'qtest_is_old_versioned_machine':
> tests/libqtest.c:1019:13: warning: array subscript has type 'char'
> [-Wchar-subscripts]
>              if (!isdigit(*chr) && *chr != '.') {
>              ^
> 
> Code should be using qemu_isdigit(). We don't enforce -Werror
> on NetBSD, though, so we could let this through and fix it up
> later...

As you prefer.  I can send a v4 too.

> Test failure on x86-64 Linux (debug build):
> 
> 
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> gtester -k --verbose -m=qui
> ck tests/test-replication
> TEST: tests/test-replication... (pid=6535)
>   /replication/primary/read:                                           OK
>   /replication/primary/write:                                          OK
>   /replication/primary/start:                                          OK
>   /replication/primary/stop:                                           OK
>   /replication/primary/do_checkpoint:                                  OK
>   /replication/primary/get_error_all:                                  OK
>   /replication/secondary/read:                                         OK
>   /replication/secondary/write:                                        OK
>   /replication/secondary/start:                                        **
> ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-replication.c:120:test_blk_write:
> assertion failed: (async_ret == 0)
> FAIL
> GTester: last random seed: R02Sb173bafaddab398fce3309452c295220
> (pid=6688)
>   /replication/secondary/stop:                                         OK
>   /replication/secondary/do_checkpoint:                                OK
>   /replication/secondary/get_error_all:                                OK
> FAIL: tests/test-replication
> 
> I'm just checking whether that fails consistently or if it's a random/
> intermittent.

That would be strange, since I'm not touching the block layer at all
(not my turf!)...

Paolo