Re: [Qemu-devel] [PATCH for-3.1 08/10] hw/s390x: Move vhost-vsock-ccw code to a separate file

[Cornelia Huck]

On Wed, 25 Jul 2018 14:20:22 +0200
Thomas Huth <address@hidden> wrote:

> The code should only be enabled if CONFIG_VHOST_VSOCK has been set.
> This can be done best if the code resides in a separate file.
> 
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  hw/s390x/Makefile.objs     |  1 +
>  hw/s390x/vhost-vsock-ccw.c | 60 
> ++++++++++++++++++++++++++++++++++++++++++++++

Small nit: The existing MAINTAINERS entry for virtio-ccw doesn't catch
this (although the virtio-ccw machine one does). I'll squash in the
following:

diff --git a/MAINTAINERS b/MAINTAINERS
index f823fdec91..6d01cd00af 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1228,6 +1228,7 @@ M: Cornelia Huck <address@hidden>
 M: Christian Borntraeger <address@hidden>
 S: Supported
 F: hw/s390x/virtio-ccw*.[hc]
+F: hw/s390x/vhost-vsock-ccw.c
 T: git git://github.com/cohuck/qemu.git s390-next
 T: git git://github.com/borntraeger/qemu.git s390-next
 L: address@hidden

>  hw/s390x/virtio-ccw.c      | 47 ------------------------------------
>  3 files changed, 61 insertions(+), 47 deletions(-)
>  create mode 100644 hw/s390x/vhost-vsock-ccw.c