Re: [Qemu-devel] [PATCH v3 07/10] check: Only test boot-serial when sga is compiled in

[Juan Quintela]

Thomas Huth <address@hidden> wrote:
> On 2018-08-22 11:54, Juan Quintela wrote:
>> This is only for x86* architecture.
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>>  tests/Makefile.include | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>> index 116e93cdb6..d524e1bdeb 100644
>> --- a/tests/Makefile.include
>> +++ b/tests/Makefile.include
>> @@ -257,7 +257,7 @@ check-qtest-i386-y += tests/hd-geo-test$(EXESUF)
>>  gcov-files-i386-y += hw/block/hd-geometry.c
>>  check-qtest-i386-y += tests/boot-order-test$(EXESUF)
>>  check-qtest-i386-y += tests/bios-tables-test$(EXESUF)
>> -check-qtest-i386-y += tests/boot-serial-test$(EXESUF)
>> +check-qtest-i386-$(CONFIG_SGA) += tests/boot-serial-test$(EXESUF)
>
> Reviewed-by: Thomas Huth <address@hidden>
>
> Off-topic: I wonder whether we could even deprecate the SGA device
> nowadays, since the main seabios now can redirect the console to the
> serial port, too?

No idea, but then I think we can deprecate it, we already have enough
weird things around.

Thanks, Juan.