Re: [Qemu-devel] [PATCH] docker: Clean dangling tarball files

[Fam Zheng]

On Sat, 08/18 00:03, Philippe Mathieu-Daudé wrote:
> When a container fails, it leaves a dangling tarball which name is
> based on a timestamp. Further uses of make won't clean those files,
> neither calling the 'docker-clean' target.
> 
> Use the .DELETE_ON_ERROR built-in target to let make remove those
> temporary tarballs in case of failure.
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  tests/docker/Makefile.include | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index d3101afecd..6e03235ab9 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -25,6 +25,7 @@ IMAGES ?= %
>  CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.$$$$)
>  DOCKER_SRC_COPY := $(BUILD_DIR)/docker-src.$(CUR_TIME)
>  
> +.DELETE_ON_ERROR: $(DOCKER_SRC_COPY)
>  $(DOCKER_SRC_COPY):
>       @mkdir $@
>       $(if $(SRC_ARCHIVE), \
> -- 
> 2.18.0
> 

Queued, thanks.

Fam