Re: [Qemu-devel] [PATCH 2/2] qobject: modify qobject_ref() to assert on NULL

[Alberto Garcia]

On Fri 17 Aug 2018 07:19:32 PM CEST, Marc-André Lureau wrote:
> diff --git a/block/quorum.c b/block/quorum.c
> index 9152da8c58..96cd094ede 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @@ -1089,7 +1089,8 @@ static void quorum_refresh_filename(BlockDriverState 
> *bs, QDict *options)
>      children = qlist_new();
>      for (i = 0; i < s->num_children; i++) {
>          qlist_append(children,
> -                     qobject_ref(s->children[i]->bs->full_open_options));
> +                     s->children[i]->bs->full_open_options ?
> +                     qobject_ref(s->children[i]->bs->full_open_options) : 
> NULL);
>      }
>  
>      opts = qdict_new();

Reviewed-by: Alberto Garcia <address@hidden>

Berto