Re: [Qemu-devel] [PATCH 0/5] tcg: Reorg 128-bit atomic operations

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/5] tcg: Reorg 128-bit atomic operations

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f737708dc7 target/ppc: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128
033218b7f9 target/arm: Convert to HAVE_CMPXCHG128
da2a6aef8e target/s390x: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128
d808c041c2 target/i386: Convert to HAVE_CMPXCHG128
0b37069534 tcg: Split CONFIG_ATOMIC128

=== OUTPUT BEGIN ===
Checking PATCH 1/5: tcg: Split CONFIG_ATOMIC128...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#181: 
new file mode 100644

ERROR: space prohibited before open square bracket '['
#255: FILE: include/qemu/atomic128.h:70:
+        : [mem] "+m"(*ptr), [tmp] "=&r"(tmp),

ERROR: space prohibited before open square bracket '['
#257: FILE: include/qemu/atomic128.h:72:
+        : [cmpl] "r"(cmpl), [cmph] "r"(cmph),

WARNING: architecture specific defines should be avoided
#280: FILE: include/qemu/atomic128.h:95:
+# ifdef __aarch64__

ERROR: space prohibited before open square bracket '['
#291: FILE: include/qemu/atomic128.h:106:
+        : [mem] "+m"(*ptr), [tmp] "=r"(tmp), [l] "=r"(l), [h] "=r"(h));

ERROR: space prohibited before open square bracket '['
#304: FILE: include/qemu/atomic128.h:119:
+        : [mem] "+m"(*ptr), [t1] "=&r"(t1), [t2] "=&r"(t2)

ERROR: space prohibited before open square bracket '['
#305: FILE: include/qemu/atomic128.h:120:
+        : [l] "r"(l), [h] "r"(h));

total: 5 errors, 2 warnings, 350 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/5: target/i386: Convert to HAVE_CMPXCHG128...
Checking PATCH 3/5: target/s390x: Convert to HAVE_CMPXCHG128 and 
HAVE_ATOMIC128...
Checking PATCH 4/5: target/arm: Convert to HAVE_CMPXCHG128...
Checking PATCH 5/5: target/ppc: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden