[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 7/8] tests/device-introspect: Test with all m
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v2 7/8] tests/device-introspect: Test with all machines, not only with "none" |
Date: |
Fri, 17 Aug 2018 12:56:43 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Thomas Huth <address@hidden> wrote:
> Certain device introspection crashes used to only happen if you were
> using a certain machine, e.g. if the machine was using serial_hd() or
> nd_table[], and a device was trying to use these in its instance_init
> function, too.
>
> To be able to catch these problems, let's extend the device-introspect
> test to check the devices on all machine types, with and without the
> "-nodefaults" parameter (since this makes a difference sometimes, too).
> Since this is a rather slow operation, and most of the problems are
> already handled by testing with the "none" machine only, the test with
> all machines is only run in the "make check SPEED=slow" mode.
>
> Reviewed-by: Markus Armbruster <address@hidden>
> Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
> ---
> tests/device-introspect-test.c | 32 +++++++++++++++++++++++++++++---
> 1 file changed, 29 insertions(+), 3 deletions(-)
>
> diff --git a/tests/device-introspect-test.c b/tests/device-introspect-test.c
> index a38193b..a25092d 100644
> --- a/tests/device-introspect-test.c
> +++ b/tests/device-introspect-test.c
> @@ -221,13 +221,13 @@ static void test_device_intro_abstract(void)
> qtest_end();
> }
>
> -static void test_device_intro_concrete(void)
> +static void test_device_intro_concrete(const void *args)
^^^^^^^^^^^^^^^^
I hate this game of casts, but I have no good suggestions, sorry.
- [Qemu-devel] [PATCH v2 2/8] net: Silence 'has no peer' messages in testing mode, (continued)
- [Qemu-devel] [PATCH v2 2/8] net: Silence 'has no peer' messages in testing mode, Thomas Huth, 2018/08/16
- [Qemu-devel] [PATCH v2 3/8] hw/timer/mc146818rtc: White space clean-up, Thomas Huth, 2018/08/16
- [Qemu-devel] [PATCH v2 4/8] hw/timer/mc146818rtc: Fix introspection problem, Thomas Huth, 2018/08/16
- [Qemu-devel] [PATCH v2 8/8] MAINTAINERS: add maintainers for qtest, Thomas Huth, 2018/08/16
- [Qemu-devel] [PATCH v2 5/8] tests: Skip old versioned machine types in quick testing mode, Thomas Huth, 2018/08/16
- [Qemu-devel] [PATCH v2 7/8] tests/device-introspect: Test with all machines, not only with "none", Thomas Huth, 2018/08/16
- Re: [Qemu-devel] [PATCH v2 7/8] tests/device-introspect: Test with all machines, not only with "none",
Juan Quintela <=
- [Qemu-devel] [PATCH v2 6/8] tests/device-introspection: Check that the qom-tree and qtree do not change, Thomas Huth, 2018/08/16
- Re: [Qemu-devel] [PATCH v2 0/8] Various qtest-related patches and a mc146818rtc fix, Paolo Bonzini, 2018/08/17