[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 47/84] target/mips: Add emulation of DSP ASE
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v9 47/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 6 |
Date: |
Thu, 16 Aug 2018 10:38:37 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/16/2018 07:57 AM, Aleksandar Markovic wrote:
> From: Stefan Markovic <address@hidden>
>
> Add emulation of DSP ASE instructions for nanoMIPS - part 6.
>
> Reviewed-by: Aleksandar Markovic <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> Signed-off-by: Stefan Markovic <address@hidden>
> ---
> target/mips/translate.c | 62
> +++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index 420a296..02ae3d9 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -17777,6 +17777,64 @@ static void
> gen_pool32axf_4_nanomips_insn(DisasContext *ctx, uint32_t opc,
> tcg_temp_free(t0);
> }
>
> +static void gen_pool32axf_7_nanomips_insn(DisasContext *ctx, uint32_t opc,
> + int rt, int rs, int rd)
> +{
> + TCGv t0;
> + TCGv rs_t;
> +
> + if (rt == 0) {
> + /* Treat as NOP. */
> + return;
> + }
This...
> +
> + t0 = tcg_temp_new();
> + rs_t = tcg_temp_new();
> +
> + gen_load_gpr(rs_t, rs);
> +
> + switch (opc) {
> + case NM_SHRA_R_QB:
> + check_dspr2(ctx);
... misses out on these checks.
Better off with the gen_store_gpr calls from the other ASE patches.
r~
- [Qemu-devel] [PATCH v9 73/84] linux-user: Add target_elf.h header for nanoMIPS, (continued)
- [Qemu-devel] [PATCH v9 73/84] linux-user: Add target_elf.h header for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 52/84] target/mips: Adjust set_hflags_for_handler() for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 59/84] mips_malta: Add basic nanoMIPS boot code for Malta board, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 69/84] linux-user: Add sockbits.h header for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 76/84] linux-user: Add cpu_loop.c for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 82/84] gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 83/84] gdbstub: Add XML support for GDB for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 57/84] elf: Don't check FCR31_NAN2008 bit for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 80/84] linux-user: Add nanoMIPS linux user mode configuration support, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 47/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 6, Aleksandar Markovic, 2018/08/16
- Re: [Qemu-devel] [PATCH v9 47/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 6,
Richard Henderson <=
- [Qemu-devel] [PATCH v9 77/84] linux-user: Amend support for sigaction() syscall for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 84/84] qemu-doc: Add nanoMIPS-related items, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 54/84] target/mips: Fix ERET/ERETNC behavior related to ADEL exception, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 72/84] linux-user: Add target_structs.h header for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 62/84] target/mips: Add definition of nanoMIPS I7200 CPU, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 75/84] linux-user: Add support for nanoMIPS signal trampoline, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 74/84] linux-user: Add signal.c for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 78/84] linux-user: Add support for statx() syscall for all platforms, Aleksandar Markovic, 2018/08/16