Re: [Qemu-devel] [PATCH v9 42/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 1

[Richard Henderson]

On 08/16/2018 07:57 AM, Aleksandar Markovic wrote:
> +    case NM_REPL_PH:
> +        check_dsp(ctx);
> +        {
> +            int16_t imm;
> +            imm = extract32(ctx->opcode, 11, 11);
> +            imm = (int16_t)(imm << 6) >> 6;

sextract32 instead.

> +            if (rt != 0) {
> +                tcg_gen_movi_tl(cpu_gpr[rt], \
> +                                (target_long)((int32_t)imm << 16 | \
> +                                (uint16_t)imm));

dup_const(MO_16, imm).

Otherwise,
Reviewed-by: Richard Henderson <address@hidden>


r~