[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/3] arm: Add BBC micro:bit machine
From: |
Steffen Görtz |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/3] arm: Add BBC micro:bit machine |
Date: |
Thu, 16 Aug 2018 16:19:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
>> +
>> + arm_m_profile_load_kernel(ARM_CPU(first_cpu), machine->kernel_filename,
>> + NRF51_SOC(soc)->flash_size);
>> +}
>> +
>> +static void microbit_machine_init(MachineClass *mc)
>> +{
>> + mc->desc = "BBC micro:bit";
>> + mc->init = microbit_init;
>> + mc->max_cpus = 1;
>> +}
>> +DEFINE_MACHINE("microbit", microbit_machine_init);
>
> Your subclass of TYPE_MACHINE has extra state, so it can't
> use DEFINE_MACHINE (which creates a subclass whose instance_size
> is the same as the parent TYPE_MACHINE). You need to do this
> longhand:
>
Hi Peter,
this is covered in <address@hidden>
Steffen