Re: [Qemu-devel] [PATCH] config: split PVRDMA from RDMA

[Peter Maydell]

On 16 August 2018 at 10:06, Marcel Apfelbaum <address@hidden> wrote:
> In some BSD systems RDMA migration is possible while
> the pvrdma device can't be compiled because the mremap
> system call is missing.
>
> Reported-by: Rebecca Cran <address@hidden>
> Signed-off-by: Marcel Apfelbaum <address@hidden>

> +##########################################
> +# PVRDMA detection
> +
> +if test "$rdma" = "yes" ; then
> +    case "$pvrdma" in
> +    "")
> +        if test "$bsd" = "yes"; then
> +            pvrdma="no"
> +        else
> +            pvrdma="yes"
> +        fi

Please don't do tests against "which host OS is this?"
unless there is absolutely no other option. Prefer to
test for presence/absence of specific features (eg
"do we have mremap()?".

Otherwise you're likely to give the wrong answer
for other host OSes we have support for (Haiku,
Solaris) or other host OSes we add in future.

thanks
-- PMM