Re: [Qemu-devel] [PATCH v8 09/87] target/mips: Add support for availability control via bit MT

[Aleksandar Markovic]

> From: Aleksandar Markovic <address@hidden>
> Sent: Monday, August 13, 2018 7:52 PM
> 
> Subject: [PATCH v8 09/87] target/mips: Add support for availability control 
> via bit MT
> 
> From: Aleksandar Rikalo <address@hidden>
> 
> Add a field in hflags for MT bit, and functions check_mt() and
> check_cp0_mt().
> 
> Signed-off-by: Aleksandar Markovic <address@hidden>
> Signed-off-by: Stefan Markovic <address@hidden>
> ---
>  target/mips/cpu.h       |  3 ++-
>  target/mips/internal.h  |  6 +++++-
>  target/mips/translate.c | 29 +++++++++++++++++++++++++++++
>  3 files changed, 36 insertions(+), 2 deletions(-)
> 
> diff --git a/target/mips/cpu.h b/target/mips/cpu.h
> ...
> +/*
> + * This code generates a "coprocessor unusable" if CP) is not
> + * available, and, if that is not the case, generates a "reserved
> + * instruction" exception if the Config5 MT bit is NOT set.
> + * This is used for some of instructions in MT ASE.
> + */

" "coprocessor unusable" if CP) " should be " "coprocessor unusable" exception 
if CP0 ". Otherwise:

Reviewed-by: Aleksandar Markovic <address@hidden>