Re: [Qemu-devel] [PATCH 11/56] check-qjson: Cover UTF-8 in single quoted strings

[Eric Blake]

On 08/13/2018 01:11 AM, Markus Armbruster wrote:

> > > > Technically, Unicode ends at U+10FFFF (21 bits). Anything beyond that
> > > > is not valid Unicode, even if it IS a valid interpretation of UTF-8
> > > > encoding.
> > >
> > > Correct.  Testing how we handle such sequences makes sense all the same.
> > >
> > > > >             {
> > > > > -            "\"\xF7\xBF\xBF\xBF\"",
> > > > > +            "\xF7\xBF\xBF\xBF",
> > > > >                 NULL,               /* bug: rejected */
> >
> > So, maybe all the more we need to do is remove the comment (as we WANT
> > to reject these)?
>
> Is PATCH 20 doing what you suggest?

Yes, I think you get there in the end, it was more a question of churn 
in the meantime.

> > > > The conversion of the initializer looks sane (well, mechanical).  Ergo:
> > > >
> > > > Reviewed-by: Eric Blake <address@hidden>
> > >
> > > Thanks!
> >
> > Of course, playing games with the pre-existing comments on
> > out-of-range behavior is probably better for a separate patch, and you
> > do have some churn on these tests in later patches. I'll leave it up
> > to you what to do (or leave put).

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org