[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] sh4: fix use_icount with linux-user
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH] sh4: fix use_icount with linux-user |
Date: |
Fri, 10 Aug 2018 19:41:26 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/10/2018 03:25 PM, Laurent Vivier wrote:
> +++ b/target/sh4/translate.c
> @@ -253,7 +253,6 @@ static void gen_goto_tb(DisasContext *ctx, int n,
> target_ulong dest)
> tcg_gen_lookup_and_goto_ptr();
> }
> }
> - ctx->base.is_jmp = DISAS_NORETURN;
> }
>
Looking at the other places gen_goto_tb is used,
this doesn't look right.
Based on the description, I expected a modification in
gen_conditional_jump, much like the one you remove here:
> @@ -324,7 +323,6 @@ static void gen_delayed_conditional_jump(DisasContext *
> ctx)
> gen_jump(ctx);
>
> gen_set_label(l1);
> - ctx->base.is_jmp = DISAS_NEXT;
> return;
> }
>
r~