Re: [Qemu-devel] [PATCH v7 04/80] target/mips: Fix two instances of shadow variables

[Philippe Mathieu-Daudé]

On 08/06/2018 01:59 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <address@hidden>
> 
> Fix two instances of shadow variables. This cleans up entire file
> translate.c from shadow variables.
> 
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> Signed-off-by: Stefan Markovic <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  target/mips/translate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index e32fd5f..d6eccc9 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -13247,7 +13247,7 @@ static void gen_pool16c_r6_insn(DisasContext *ctx)
>              gen_arith_imm(ctx, OPC_ADDIU, 29, 29, imm << 2);
>          } else {
>              /* JRC16 */
> -            int rs = extract32(ctx->opcode, 5, 5);
> +            rs = extract32(ctx->opcode, 5, 5);
>              gen_compute_branch(ctx, OPC_JR, 2, rs, 0, 0, 0);
>          }
>          break;
> @@ -15249,7 +15249,7 @@ static void decode_micromips32_opc(CPUMIPSState *env, 
> DisasContext *ctx)
>          } else {
>              /* ADDIUPC */
>              int reg = mmreg(ZIMM(ctx->opcode, 23, 3));
> -            int offset = SIMM(ctx->opcode, 0, 23) << 2;
> +            offset = SIMM(ctx->opcode, 0, 23) << 2;
>  
>              gen_addiupc(ctx, reg, offset, 0, 0);
>          }
>