[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 06/11] iotests: Add tests for mirror @replace
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 06/11] iotests: Add tests for mirror @replaces loops |
Date: |
Fri, 10 Aug 2018 00:47:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-10 00:31, Max Reitz wrote:
> This adds two tests for cases where our old check_to_replace_node()
> function failed to detect that executing this job with these parameters
> would result in a cyclic graph.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/041 | 124 +++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/041.out | 4 +-
> 2 files changed, 126 insertions(+), 2 deletions(-)
Sometimes, I hate myself a little bit. I totally forgot to run the test
with QED.
So:
> diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
> index c20ac7da87..186bd0f031 100755
> --- a/tests/qemu-iotests/041
> +++ b/tests/qemu-iotests/041
> @@ -1061,5 +1061,129 @@ class TestOrphanedSource(iotests.QMPTestCase):
[...]
> + 'driver': 'qcow2',
[...]
> + 'driver': 'qcow2',
[...]
> + 'driver': 'qcow2',
Imagine these to be "'driver': iotests.imgfmt". With that, it passes.
(I won't send a v3 specifically for this, but it will be included in v3.
Eventually.)
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/11] block: Deal with filters, Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH v2 01/11] block: Mark commit and mirror as filter drivers, Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH v2 02/11] blockdev: Check @replaces in blockdev_mirror_common, Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH v2 06/11] iotests: Add tests for mirror @replaces loops, Max Reitz, 2018/08/09
- Re: [Qemu-devel] [PATCH v2 06/11] iotests: Add tests for mirror @replaces loops,
Max Reitz <=
- [Qemu-devel] [PATCH v2 05/11] block: Fix check_to_replace_node(), Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH v2 07/11] block: Leave BDS.backing_file constant, Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH v2 04/11] block: Storage child access function, Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH v2 08/11] iotests: Add filter commit test cases, Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH v2 09/11] iotests: Add filter mirror test cases, Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH v2 11/11] iotests: Test committing to overridden backing, Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH v2 03/11] block: Filtered children access functions, Max Reitz, 2018/08/09
- [Qemu-devel] [PATCH v2 10/11] iotests: Add test for commit in sub directory, Max Reitz, 2018/08/09
- Re: [Qemu-devel] [PATCH v2 00/11] block: Deal with filters, Max Reitz, 2018/08/09
- Re: [Qemu-devel] [PATCH v2 00/11] block: Deal with filters, Max Reitz, 2018/08/29