Re: [Qemu-devel] [PATCH 13/56] check-qjson: Fix utf8_string() to test all invalid sequences

[Eric Blake]

On 08/08/2018 07:02 AM, Markus Armbruster wrote:
> Some of utf8_string()'s test_cases[] contain multiple invalid
> sequences.  Testing that qobject_from_json() fails only tests we
> reject at least one invalid sequence.  That's incomplete.
>
> Additionally test each non-space sequence in isolation.
>
> This demonstrates that the JSON parser accepts invalid sequences
> starting with \xC2..\xF4.  Add a FIXME comment.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   tests/check-qjson.c | 33 ++++++++++++++++++++++++++++-----
>   1 file changed, 28 insertions(+), 5 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org