Re: [Qemu-devel] [PATCH v2 05/34] tests/qgraph: sdhci driver and interface nodes

[Laurent Vivier]

On 09/08/2018 12:15, Paolo Bonzini wrote:
> On 09/08/2018 12:10, Laurent Vivier wrote:
>>>  libqgraph-pci-obj-y = $(libqos-pc-obj-y)
>>>  libqgraph-pci-obj-y += $(libqgraph-machines-obj-y)
>>> +libqgraph-pci-obj-y += tests/libqos/sdhci.o
>> The file also implements memory mapped SDHCI, should we split the file
>> in two files, one added to libqgraph-pci-obj-y and the other to
>> check-qtest-arm-y and check-qtest-aarch64-y?
>>
> 
> No, there is only one libqgraph.  The same test (qos-test) can run for
> both PCI and non-PCI machines, and will cull the unnecessary part of the
> graph automatically simply because there is no path from a machine to a
> PCI device.

So, all libqgraph files should be added to check-qtest-generic-y?

Thanks,
Laurent