[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 04/10] hw/m68k: add video card
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RFC v3 04/10] hw/m68k: add video card |
Date: |
Tue, 7 Aug 2018 10:44:51 +0200 |
User-agent: |
NeoMutt/20180622 |
> > +#define WRITE_BITS 8
> > +#include "macfb-template.h"
> > +
> > +#define WRITE_BITS 16
> > +#include "macfb-template.h"
> > +
> > +#define WRITE_BITS 24
> > +#include "macfb-template.h"
> > +
> > +#define WRITE_BITS 32
> > +#include "macfb-template.h"
>
> Not sure, but do we still need all these "destination" bit depth
> nowadays? I thought QEMU only supports 32 bit depths these days?
Well, qemu UI code can handle non-32 bit depths too (pretty much
anything pixman supports to be exact).
But, yes, qemu hands out 32bit DisplaySurfaces by default, i.e. when
using qemu_console_resize() or qemu_create_displaysurface() in display
device emulation.
You can ask for something else, using qemu_create_displaysurface_from(),
which is typically used in case the backing storage for the
DisplaySurface is guest memory, to avoid copying/converting display
data. The code above probably doesn't look like it is doing that though.
HTH,
Gerd
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [RFC v3 04/10] hw/m68k: add video card,
Gerd Hoffmann <=