[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 03/21] block/backup: utilize job_exit shim
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH 03/21] block/backup: utilize job_exit shim |
Date: |
Tue, 7 Aug 2018 00:33:31 -0400 |
Utilize the job_exit shim by simply not calling job_defer_to_main_loop.
Signed-off-by: John Snow <address@hidden>
---
block/backup.c | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/block/backup.c b/block/backup.c
index f3bf842423..af6ee5ab54 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -380,18 +380,6 @@ static BlockErrorAction backup_error_action(BackupBlockJob
*job,
}
}
-typedef struct {
- int ret;
-} BackupCompleteData;
-
-static void backup_complete(Job *job, void *opaque)
-{
- BackupCompleteData *data = opaque;
-
- job_completed(job, data->ret);
- g_free(data);
-}
-
static bool coroutine_fn yield_and_check(BackupBlockJob *job)
{
uint64_t delay_ns;
@@ -483,7 +471,6 @@ static void
backup_incremental_init_copy_bitmap(BackupBlockJob *job)
static void coroutine_fn backup_run(void *opaque)
{
BackupBlockJob *job = opaque;
- BackupCompleteData *data;
BlockDriverState *bs = blk_bs(job->common.blk);
int64_t offset, nb_clusters;
int ret = 0;
@@ -584,9 +571,7 @@ static void coroutine_fn backup_run(void *opaque)
qemu_co_rwlock_unlock(&job->flush_rwlock);
hbitmap_free(job->copy_bitmap);
- data = g_malloc(sizeof(*data));
- data->ret = ret;
- job_defer_to_main_loop(&job->common.job, backup_complete, data);
+ job->common.job.ret = ret;
}
static const BlockJobDriver backup_job_driver = {
--
2.14.4
[Qemu-devel] [PATCH 18/21] block/commit: refactor stream to use job callbacks, John Snow, 2018/08/07
[Qemu-devel] [PATCH 15/21] block/stream: add block job creation flags, John Snow, 2018/08/07
[Qemu-devel] [PATCH 03/21] block/backup: utilize job_exit shim,
John Snow <=
[Qemu-devel] [PATCH 14/21] block/mirror: add block job creation flags, John Snow, 2018/08/07
[Qemu-devel] [PATCH 10/21] tests/test-bdrv-drain: utilize job_exit shim, John Snow, 2018/08/07
[Qemu-devel] [PATCH 19/21] qapi/block-commit: expose new job properties, John Snow, 2018/08/07
[Qemu-devel] [PATCH 20/21] qapi/block-mirror: expose new job properties, John Snow, 2018/08/07
[Qemu-devel] [PATCH 12/21] jobs: allow entrypoints to return status code, John Snow, 2018/08/07
[Qemu-devel] [PATCH 07/21] block/create: utilize job_exit shim, John Snow, 2018/08/07
[Qemu-devel] [PATCH 06/21] block/stream: utilize job_exit shim, John Snow, 2018/08/07