[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] target/arm: Fix typo in do_sat_addsub_64
From: |
Laurent Desnogues |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] target/arm: Fix typo in do_sat_addsub_64 |
Date: |
Wed, 1 Aug 2018 15:30:01 +0200 |
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson
<address@hidden> wrote:
> Used the wrong temporary in the computation of subtractive overflow.
>
> Reported-by: Laurent Desnogues <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Laurent Desnogues <address@hidden>
Tested-by: Laurent Desnogues <address@hidden>
Laurent
> ---
> target/arm/translate-sve.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
> index 374051cd20..9dd4c38bab 100644
> --- a/target/arm/translate-sve.c
> +++ b/target/arm/translate-sve.c
> @@ -1625,7 +1625,7 @@ static void do_sat_addsub_64(TCGv_i64 reg, TCGv_i64
> val, bool u, bool d)
> /* Detect signed overflow for subtraction. */
> tcg_gen_xor_i64(t0, reg, val);
> tcg_gen_sub_i64(t1, reg, val);
> - tcg_gen_xor_i64(reg, reg, t0);
> + tcg_gen_xor_i64(reg, reg, t1);
> tcg_gen_and_i64(t0, t0, reg);
>
> /* Bound the result. */
> --
> 2.17.1
>
- [Qemu-devel] [PATCH 0/4] target/arm sve fixes, Richard Henderson, 2018/08/01
- [Qemu-devel] [PATCH 1/4] target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw, Richard Henderson, 2018/08/01
- [Qemu-devel] [PATCH 4/4] target/arm: Fix typo in helper_sve_movz_d, Richard Henderson, 2018/08/01
- [Qemu-devel] [PATCH 2/4] target/arm: Fix typo in do_sat_addsub_64, Richard Henderson, 2018/08/01
- Re: [Qemu-devel] [PATCH 2/4] target/arm: Fix typo in do_sat_addsub_64,
Laurent Desnogues <=
- [Qemu-devel] [PATCH 3/4] target/arm: Reorganize SVE WHILE, Richard Henderson, 2018/08/01
- Re: [Qemu-devel] [PATCH 0/4] target/arm sve fixes, Laurent Desnogues, 2018/08/01
- Re: [Qemu-devel] [PATCH 0/4] target/arm sve fixes, Alex Bennée, 2018/08/01
- Re: [Qemu-devel] [PATCH 0/4] target/arm sve fixes, no-reply, 2018/08/01
- Re: [Qemu-devel] [PATCH 0/4] target/arm sve fixes, no-reply, 2018/08/02
- Re: [Qemu-devel] [PATCH 0/4] target/arm sve fixes, Peter Maydell, 2018/08/03