Re: [Qemu-devel] [PATCH v5 38/76] target/mips: Add emulation of DSP ASE for nanoMIPS - part 1

[Richard Henderson]

On 07/30/2018 12:12 PM, Aleksandar Markovic wrote:
> +    case OPC_CMPGU_EQ_QB:
> +        check_dsp(ctx);
> +        gen_helper_cmpgu_eq_qb(cpu_gpr[ret], v1_t, v2_t);
> +        break;

Missing a test for ret == 0, here and many other places.
I believe some (many?) of these have side-effects, so you'll
probably want to store into e.g. v1_t and gen_store_gpr.


r~