[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] migration: Add qmp command for migrate_set_
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] migration: Add qmp command for migrate_set_max_cpu_throttle |
Date: |
Tue, 31 Jul 2018 16:50:43 +0100 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Tue, Jul 31, 2018 at 04:48:35PM +0200, Juan Quintela wrote:
> "Dr. David Alan Gilbert" <address@hidden> wrote:
> > * Li Qiang (address@hidden) wrote:
> >> The default max cpu throttle is 99, this is too big that may
> >> influence the guest loads. Add a qmp to config it can make it
> >> more flexible.
> >>
> >> Signed-off-by: Li Qiang <address@hidden>
> >
> > This should be done as a migration parameter rather than a new command.
> > For example, follow the cpu-throttle-increment parameter; and this
> > should work just like it.
>
> I was about to comment this one.
>
> migrate_set_downtime, migrate_set_speed, migrate-set-cache-size,
> query-migrate-cache-size are marked as deprecated. Any way that we
> could have make more clear that one should use
> migrate_set/get_parameter/capability?
Where are they marked as deprecated ?
They're not included in our official list of deprecated features, so per
our deprecation policy, they are still considered supported.
https://qemu.weilnetz.de/doc/qemu-doc.html#Deprecated-features
To deprecate something it needs to be added to qemu-deprecated.texi, and
ideally also made to print a message to stderr when triggered.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[Qemu-devel] [PATCH 3/3] hmp: add hmp for migrate_set_max_cpu_throttle, Li Qiang, 2018/07/31