[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/7] hw/arm: rename armv7m_load_kernel()
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/7] hw/arm: rename armv7m_load_kernel() |
Date: |
Mon, 30 Jul 2018 18:30:14 +0100 |
On 25 July 2018 at 09:59, Stefan Hajnoczi <address@hidden> wrote:
> ARMv6-M and ARMv8-M need the same kernel loading functionality as
> ARMv7-M. Rename armv7m_load_kernel() to arm_m_profile_load_kernel() so
> it's clear that this function isn't specific to ARMv7-M.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> hw/arm/Makefile.objs | 1 +
> include/hw/arm/arm.h | 11 +++--
> hw/arm/arm-m-profile.c | 81 +++++++++++++++++++++++++++++++++
> hw/arm/armv7m.c | 60 ------------------------
> hw/arm/mps2-tz.c | 3 +-
> hw/arm/mps2.c | 4 +-
> hw/arm/msf2-som.c | 4 +-
> hw/arm/netduino2.c | 4 +-
> hw/arm/stellaris.c | 3 +-
> default-configs/arm-softmmu.mak | 1 +
> 10 files changed, 99 insertions(+), 73 deletions(-)
> create mode 100644 hw/arm/arm-m-profile.c
Another rename that shows up in the patch as "delete the old
one and have a copy somewhere else". Maybe this can be fixed
with suitable git rename-detection options?
thanks
-- PMM