Re: [Qemu-devel] [PULL 0/3] QObject patches for 2018-07-27 (3.0.0-rc3)

[Markus Armbruster]

Peter Maydell <address@hidden> writes:

> On 27 July 2018 at 16:55, Markus Armbruster <address@hidden> wrote:
>> The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc:
>>
>>   Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://repo.or.cz/qemu/armbru.git tags/pull-qobject-2018-07-27
>>
>> for you to fetch changes up to 307fb894ce0608aede990ec40ce84eaeb358c8ec:
>>
>>   qstring: Move qstring_from_substr()'s @end one to the right (2018-07-27 
>> 17:16:03 +0200)
>>
>> ----------------------------------------------------------------
>> QObject patches for 2018-07-27 (3.0.0-rc3)
>>
>> This pull request fixes an integer overflow bug, and hardens the code
>> in question a bit.  Abuse of QMP can make the bug crash QEMU, so it
>> seems worth fixing at this late stage.
>>
>> ----------------------------------------------------------------
>> Markus Armbruster (2):
>>       qstring: Assert size calculations don't overflow
>>       qstring: Move qstring_from_substr()'s @end one to the right
>>
>> liujunjie (1):
>>       qstring: Fix qstring_from_substr() not to provoke int overflow
>
>
> Hi -- this passes my buildtests, but the commit from liujunjie
> seems to be missing your maintainer signed-off-by (and possibly
> a reviewed-by tag ?) Can I ask you to fix that up and resend,
> please?

My apologies.  v2 sent.