|
From: | Cédric Le Goater |
Subject: | Re: [Qemu-devel] [PATCH v2 1/2] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge |
Date: | Fri, 27 Jul 2018 09:33:55 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
>>> That said... shouldn't you filter our invalid or read-only regs before >>> updating the cache? >> >> hmm, the current model relies on the fact that some registers have >> their value implicitly updated. But I guess, we can dump which are >> accessed and implement a default behavior for these. I will take a >> look. > > I don't really follow what you're saying here, but I guess I'll see > what it looks like in te next spin. My idea was to printf the registers being used and populate the switch statement, but there are too many of them and it would only pollute the code for not much benefit I think I will keep it as it is and may be fix a few things if possible. C.
[Prev in Thread] | Current Thread | [Next in Thread] |