Re: [Qemu-devel] [PATCH v5 1/3] spapr: introduce a fixed IRQ number space

[Cédric Le Goater]

>> +        /*
>> +         * Other VIO devices register values, when allocated by
>> +         * livirt, are mapped in range [0x00 - 0xef].
>> +         */
>> +        irq = (reg >> 12) & 0xef;
> 
> This mask doesn't do what you intend - it will map 0x10 to 0, for

oops. yes indeed.

> example.  You could use % 0xf0, but actually you might as well just
> use & 0xff.  Yes, it could collide with the vty devices, but either
> way you can still have collisions if you try hard enough.  
> And, either way, they'll get detected later.

I will do that.

C.