Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

[Eric Blake]

On 07/25/2018 03:26 AM, Kevin Wolf wrote:

> > @@ -2840,6 +2845,7 @@
> >               '*overlap-check': 'Qcow2OverlapChecks',
> >               '*cache-size': 'int',
> >               '*l2-cache-size': 'int',
> > +            '*l2-cache-full': 'bool',
> >               '*l2-cache-entry-size': 'int',
> >               '*refcount-cache-size': 'int',
> >               '*cache-clean-interval': 'int',
>
> Only looking at the external interface for now, I wonder whether it
> would be nicer not to have two mutually exclusive options, but to make
> l2-cache-size an alternate that can take either an int like before
> (meaning the number of bytes) or a string/enum (with the only accepted
> value "full" for now).

That does sound interesting.

> Another interesting question is whether 'full' shouldn't keep meaning
> full throughout the lifetime of the BlockDriverState, i.e. should it
> keep adapting to the new size when the image size changes?

Do we even resize the cache now for image size changes? If we use an 
enum, we could have two different values depending on whether the chosen 
cache size remains fixed or also tries to resize when the image grows.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org