|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH] monitor: print message when using 'help' with an unknown command |
Date: | Fri, 20 Jul 2018 11:40:02 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/19/2018 11:39 AM, Collin Walling wrote:
On 07/19/2018 12:31 PM, Markus Armbruster wrote:You neglected to cc: maintainers. Cc'ing them increases the odds your patch will be noticed and picked up. You can use scripts/get_maintainer.pl to find maintainers. You don't have to do anything for this patch; it got noticed anyway. David, this is yours :)Very true. Was a minor fix that I thought I'd just toss it out there and let anyone view it if they had the time. Will be more aware of who to CC next time around.
Or automate it: https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer suggests:
git config sendemail.cccmd 'scripts/get_maintainer.pl --nogit-fallback' -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |