[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.0 ?] tests/libqtest: Improve kill_qemu() a
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH for-3.0 ?] tests/libqtest: Improve kill_qemu() assert |
Date: |
Fri, 20 Jul 2018 17:25:29 +0100 |
On 20 July 2018 at 17:14, Richard Henderson
<address@hidden> wrote:
> You already print the file, just include the line. Perhaps
>
> fprintf(stderr,
> "%s:%d: kill_qemu tried to terminate QEMU "
> "process but it dumped core with signal %s\n",
> __FILE__, __LINE__, strsignal(WTERMSIG(wstatus)));
> abort();
I wasn't convinced that strsignal() would be available
on all the host OSes we build on (we don't currently use
it outside linux-user/), and I definitely didn't think that
it merited a configure test for its presence just for a
test error message :-)
thanks
-- PMM
Re: [Qemu-devel] [PATCH for-3.0 ?] tests/libqtest: Improve kill_qemu() assert, Michael S. Tsirkin, 2018/07/22
Re: [Qemu-devel] [PATCH for-3.0 ?] tests/libqtest: Improve kill_qemu() assert, Alex Bennée, 2018/07/23