Re: [Qemu-devel] [PATCH] hw/timer/mc146818rtc: Fix introspection problem

[Peter Maydell]

On 19 July 2018 at 15:23, Thomas Huth <address@hidden> wrote:
> There is currently a funny problem with the "mc146818rtc" device:
> 1) Start QEMU like this:
>    qemu-system-ppc64 -M pseries -S
> 2) At the HMP monitor, enter "info qom-tree". Note that there is an
>    entry for "/rtc (spapr-rtc)".
> 3) Introspect the mc146818rtc device like this:
>    device_add mc146818rtc,help
> 4) Run "info qom-tree" again. The "/rtc" entry is gone now!
>
> The rtc_finalize() function of the mc146818rtc device has two bugs: First,
> it tries to remove a "rtc" property, while the rtc_realizefn() added a
> "rtc-time" property instead. And second, it should be done in an unrealize
> function, not in a finalize function, to avoid that this causes problems
> during introspection.

A device that adds a property to a machine is pretty weird...

thanks
-- PMM