[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] qemu-iotests: workaround to avoid Python3 while running tes
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] qemu-iotests: workaround to avoid Python3 while running tests on Fedora Docker image |
Date: |
Tue, 17 Jul 2018 20:37:58 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
I noticed this while running "make address@hidden":
$ make address@hidden NETWORK=1
BUILD fedora
RUN test-block in qemu:fedora
Configure options:
--enable-werror --prefix=/tmp/qemu-test/install
--python=/usr/bin/python3 --target-list=x86_64-softmmu
...
python /usr/bin/python3 -B
...
194 - output mismatch (see 194.out.bad)
--- /tmp/qemu-test/src/tests/qemu-iotests/194.out 2018-07-17
22:51:10.000000000 +0000
+++ /tmp/qemu-test/build/tests/qemu-iotests/194.out.bad 2018-07-17
22:58:01.646916625 +0000
@@ -1,18 +1,18 @@
Launching VMs...
Launching NBD server on destination...
-{u'return': {}}
-{u'return': {}}
+{'return': {}}
+{'return': {}}
and many more errors, until:
Failures: 045 132 148 152 162 169 194 205 208 218 222
Failed 11 of 49 tests
Test failed: iotests raw
All failures are due to Python2 syntax.
I started to fix but noticed there are too many and this isn't to
correct fix for this release.
I suppose we don't want to use Py3 for iotests.
The bisect was obvious =)
commit 356dc290f0ef930a24b6af3a0908b1cb58ad47c9
Author: Daniel P. Berrange <address@hidden>
Date: Tue Jan 16 13:42:17 2018 +0000
docker: change Fedora images to run with python3
Fedora has switched to Python 3 by default, so it
makes sense to use that for testing QEMU builds,
so we get testing of Python 3 compatibility.
Signed-off-by: Daniel P. Berrange <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
which added:
ENV QEMU_CONFIGURE_OPTS --python=/usr/bin/python3
I then figured out we can use EXTRA_CONFIGURE_OPTS:
$ make address@hidden NETWORK=1 \
EXTRA_CONFIGURE_OPTS=--python=/usr/bin/python2
COPY RUNNER
RUN test-block in qemu:fedora
Configure options:
--enable-werror --prefix=/tmp/qemu-test/install
--python=/usr/bin/python3 --python=/usr/bin/python2
--target-list=x86_64-softmmu
...
python /usr/bin/python2 -B
...
Passed all 48 tests
PLATFORM -- Linux/aarch64 757be6ea0325 4.15.0-20-generic
So let's use this simple workaround :)
EXTRA_CONFIGURE_OPTS=--python=/usr/bin/python2
Regards,
Phil.
- [Qemu-devel] qemu-iotests: workaround to avoid Python3 while running tests on Fedora Docker image,
Philippe Mathieu-Daudé <=