Re: [Qemu-devel] [PATCH] hw/microblaze/xlnx-zynqmp-pmu: Fix introspection problem in 'xlnx, zynqmp-pmu-soc'

[Peter Maydell]

On 17 July 2018 at 18:37, Edgar E. Iglesias <address@hidden> wrote:
> On Tue, Jul 17, 2018 at 04:55:43PM +0200, Thomas Huth wrote:
>> Valgrind complains:
>>
>> echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \
>>  "'arguments':{'typename':'xlnx,zynqmp-pmu-soc'}}" \
>>  "{'execute': 'human-monitor-command', " \
>>  "'arguments': {'command-line': 'info qtree'}}" | \
>>  valgrind -q microblazeel-softmmu/qemu-system-microblazeel -M 
>> none,accel=qtest -qmp stdio
>> [...]
>> ==13605== Invalid read of size 8
>> ==13605==    at 0x2AC69A: qdev_print (qdev-monitor.c:686)
>> ==13605==    by 0x2AC69A: qbus_print (qdev-monitor.c:719)
>> ==13605==    by 0x2591E8: handle_hmp_command (monitor.c:3446)
>>
>> Use the new object_initialize_child() and sysbus_init_child_obj() to
>> fix the issue.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>
>
> Reviewed-by: Edgar E. Iglesias <address@hidden>
>
> Peter, could you pick this up for 3.0? Or do you want a pull request?

It's missed rc1 but I'll put it in via target-arm.next for rc2.

thanks
-- PMM