Re: [Qemu-devel] [qemu-s390x] [RFC 06/15] s390-bios: Clean up cio.h

[Richard Henderson]

On 07/17/2018 11:15 AM, Thomas Huth wrote:
>> -    __u32 isc:3;
>> -    __u32 ena:1;
>> -    __u32 mme:2;
>> -    __u32 mp:1;
>> -    __u32 csense:1;
>> -    __u32 mbfc:1;
>> +    __u32 isc    : 3;
>> +    __u32 ena    : 1;
>> +    __u32 mme    : 2;
>> +    __u32 mp     : 1;
>> +    __u32 csense : 1;
>> +    __u32 mbfc   : 1;
> 
> checkpatch.pl does not like these spaces, so I think it would be better
> to not make these changes (otherwise we'll have to deal with the output
> of checkpatch each time again we want to change something here).

AFAICT, this is a checkpatch bug confusing switch case labels.


r~