[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 20/25] check: Only test usb-xhci-nec when it is
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 20/25] check: Only test usb-xhci-nec when it is compiled in |
Date: |
Tue, 17 Jul 2018 19:06:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Thomas Huth <address@hidden> wrote:
> On 17.07.2018 13:33, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> tests/Makefile.include | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>> index b3e707e8c3..ccf71bddcc 100644
>> --- a/tests/Makefile.include
>> +++ b/tests/Makefile.include
>> @@ -288,8 +288,8 @@ check-qtest-i386-y += tests/usb-hcd-ehci-test$(EXESUF)
>> gcov-files-i386-y += hw/usb/hcd-ehci.c
>> gcov-files-i386-y += hw/usb/dev-hid.c
>> gcov-files-i386-y += hw/usb/dev-storage.c
>> -check-qtest-i386-y += tests/usb-hcd-xhci-test$(EXESUF)
>> -gcov-files-i386-y += hw/usb/hcd-xhci.c
>> +check-qtest-i386-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF)
>> +gcov-files-i386-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c
>> check-qtest-i386-y += tests/cpu-plug-test$(EXESUF)
>> check-qtest-i386-y += tests/q35-test$(EXESUF)
>> check-qtest-i386-y += tests/vmgenid-test$(EXESUF)
>> @@ -347,8 +347,8 @@ check-qtest-ppc64-y += tests/usb-hcd-ohci-test$(EXESUF)
>> gcov-files-ppc64-y += hw/usb/hcd-ohci.c
>> check-qtest-ppc64-y += tests/usb-hcd-uhci-test$(EXESUF)
>> gcov-files-ppc64-y += hw/usb/hcd-uhci.c
>> -check-qtest-ppc64-y += tests/usb-hcd-xhci-test$(EXESUF)
>> -gcov-files-ppc64-y += hw/usb/hcd-xhci.c
>> +check-qtest-ppc64-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF)
>> +gcov-files-ppc64-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c
>> check-qtest-ppc64-y += $(check-qtest-virtio-y)
>> check-qtest-ppc64-$(CONFIG_SLIRP) += tests/test-netfilter$(EXESUF)
>> check-qtest-ppc64-$(CONFIG_POSIX) += tests/test-filter-mirror$(EXESUF)
>
> I wonder whether the gcov lines are still up-to-date, or whether they
> should include hcd-xhci-nec.c as well? (See commit 0bbb2f3df1ffd9ccf713
> for the split)
I don't even know how to launch gcov. Not sure if I should put the
$(CONFIG_foo) there. File is not consistent at all.
Later, Juan.
- [Qemu-devel] [PATCH 18/25] check: Only test pvpanic when it is compiled in, (continued)
- [Qemu-devel] [PATCH 18/25] check: Only test pvpanic when it is compiled in, Juan Quintela, 2018/07/17
- [Qemu-devel] [PATCH 19/25] check: Only test nvme when it is compiled in, Juan Quintela, 2018/07/17
- [Qemu-devel] [PATCH 15/25] check: Only test i82801b11 when it is compiled in, Juan Quintela, 2018/07/17
- [Qemu-devel] [PATCH 17/25] check: Only test wdt_ib700 when it is compiled in, Juan Quintela, 2018/07/17
- [Qemu-devel] [PATCH 20/25] check: Only test usb-xhci-nec when it is compiled in, Juan Quintela, 2018/07/17
- [Qemu-devel] [PATCH 21/25] check: Only test usb-ohci when it is compiled in, Juan Quintela, 2018/07/17
- [Qemu-devel] [PATCH 22/25] check: Only test usb-uhci devices when they are compiled in, Juan Quintela, 2018/07/17
- [Qemu-devel] [PATCH 23/25] check: Only test usb-ehci when it is compiled in, Juan Quintela, 2018/07/17
- [Qemu-devel] [PATCH 24/25] check: Only test ivshm when it is compiled in, Juan Quintela, 2018/07/17
- [Qemu-devel] [PATCH 25/25] check: Only test tpm devices when they are compiled in, Juan Quintela, 2018/07/17