Re: [Qemu-devel] [PATCH 4/7 V10] hostmem-file: add the 'pmem' option

[Richard Henderson]

On 07/16/2018 11:32 PM, address@hidden wrote:
> @@ -34,6 +35,7 @@ struct HostMemoryBackendFile {
>      bool discard_data;
>      char *mem_path;
>      uint64_t align;
> +    bool is_pmem;
>  };

Sort all the bool's to the end?


> +    /* Just support these ram flags by now. */
> +    assert(ram_flags == 0 || (ram_flags & (RAM_SHARED | RAM_PMEM)));

Surely assert((ram_flags & ~(RAM_SHARED | RAM_PMEM)) == 0).

> +If the vNVDIMM backend is on the host persistent memory that can be

Grammar nit: "is in host persistent memory".

> +++ b/qemu-options.hx
> @@ -4070,6 +4070,13 @@ requires an alignment different than the default one 
> used by QEMU, eg
>  the device DAX /dev/dax0.0 requires 2M alignment rather than 4K. In
>  such cases, users can specify the required alignment via this option.
>  
> +The @option{pmem} option specifies whether the backing file specified
> +by @option{mem-path} is on the persistent memory that can be accessed

Likewise.


r~