[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 1/8] i386: Helpers to encode cache informatio
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH v8 1/8] i386: Helpers to encode cache information consistently |
|
Date: |
Tue, 17 Jul 2018 12:42:06 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Hi Eduardo,
On 07/16/2018 04:52 PM, Eduardo Habkost wrote:
> On Mon, Jul 16, 2018 at 10:20:09AM -0300, Philippe Mathieu-Daudé wrote:
> [...]
>>> +enum CacheType {
>>> + DCACHE,
>>
>> I just noticed this clashes on mips host:
> [...]
>> In file included from /usr/include/mips-linux-gnu/sys/cachectl.h:26:0,
>> from /tmp/qemu-test/src/tcg/mips/tcg-target.h:202,
>> from /tmp/qemu-test/src/include/exec/cpu-defs.h:29,
>> from /tmp/qemu-test/src/target/i386/cpu.h:34,
>> from /tmp/qemu-test/src/exec.c:23:
>> /tmp/qemu-test/src/target/i386/cpu.h:1053:5: error: expected identifier
>> before '(' token
>> DCACHE,
>> ^
>
> Oops. I will take a look and submit a fix. Thanks for the
> report!
While a quick fix is to simply rename the CacheType enums, I think this
is an #include problem.